[pull] latest from ag-grid:latest#776
Merged
Merged
Conversation
* refactor: consolidate number-checking utilities into shared helpers Add _isFiniteNumber and _toFiniteNumber to utils/number.ts and export from main-internal.ts. Replace scattered typeof+isFinite/isNaN patterns with the shared utilities at 9 callsites across community and enterprise. * refactor: strip verbose JSDoc from _isFiniteNumber/_toFiniteNumber * refactor: add blank-string coercion note to _toFiniteNumber JSDoc * refactor: introduce _clamp utility, replacing scattered Math.max/Math.min pairs Adds `_clamp(value, min, max)` to `utils/number` and exports it from `main-internal`. Replaces 19 identical two-call clamp patterns across community and enterprise with a single, readable helper. * fix build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )